Repository navigation
Keep each plan clarification and its answer in the task record and Notes (CF-7, clarification half) - #312
Merged
Conversation
taskRecord lists every question the CLI asked during the turn, from its question cards, with the answer as the card shows it: a secret one reads "(hidden)". An unanswered question reads "not answered" with why it closed (the agent withdrew it, the turn was stopped, or it ended first), and an answer Modex could not confirm the CLI received says so. Both count as not settled. Nothing is filled in that the card does not hold, and a turn with no questions has no Clarifications section. The unit test failed first: the record had no clarifications. Refs #280 Coven-Harness: Claude Code / claude-opus-5-5
e2e/plan-clarification.spec.ts runs a scripted codex-cli 0.163.0 app-server that reports a plan, asks a clarifying question through the question card, and plans on from the answer. The answer reaches Codex once, Save to Notes records it with the secret hidden, and a second clarification stopped unanswered is saved as "not answered: the turn was stopped" with no answer filled in. No file under MODEX_HOME holds the secret. Against the record code without clarifications it failed at "## Clarifications" in the saved note. docs/task-context.md describes clarifications in the record. Refs #280 Coven-Harness: Claude Code / claude-opus-5-5
Refs #280 Coven-Harness: Claude Code / claude-opus-5-5
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage-agent
View coverage of the 1 most impacted file.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
BunsDev
added a commit
that referenced
this pull request
Oct 19, 2026
CF-2 (#286), CF-3 (#293), CF-4's Markdown slice (#283), CF-6's request half (#308) and CF-7's clarifications (#312) are on main, with their merge commits. The candidate note says the fixture rows now run on main, and no candidate is pinned while the live-provider and human gates stay open. Refs #281 Coven-Harness: Claude Code / claude-opus-5-5
BunsDev
added a commit
that referenced
this pull request
Oct 19, 2026
…nd patch-comparison slice Coven-Harness: Claude Code / claude-opus-5-5
BunsDev
added a commit
that referenced
this pull request
Oct 19, 2026
…nts at once, reconnect, a clarifying question (CF-8) (#313) * Add the request variants to the fidelity path Four cases in e2e/conversation-fidelity.spec.ts, through the real app: - A native withdrawal: the Claude fixture takes its own request back (control_cancel_request). The card closes as withdrawn, no answer reaches the CLI, a late answer is refused, and the file is unchanged. - The desktop and the phone answer at once, over the bridge and the companion's HTTPS. Exactly one is accepted, the CLI reads one decision, the card names who gave it, and the file matches the winner. - With the journal on, a phone that loaded the open card reconnects after the desktop's decision. Its delta shows the card answered by the desktop and sent, its late answer is a 409, and every count stays at one. - A clarifying question inside the path, from a codex-cli 0.163.0-shaped fixture: answered on its card, heard once, followed by a real edit and check, saved to Notes, and inert after a restart that re-runs nothing. The fixture now counts every decision the CLI reads, so the earlier cases assert that too. The golden path is marked slow: since #301 it also takes 18 reference captures and relaunches, and it ran past 90 s on a Mac at load average 100. These cases found the companion's 404 for threads started on the Mac, fixed in the CF-6 branch. Refs #281 Coven-Harness: Claude Code / claude-opus-5-5 * Record the request variants in the acceptance receipt The matrix rows for a clarifying question, a native withdrawal, simultaneous answers and a reconnect after a decision move from open to verified with a fixture, with what each case asserts. The defects list adds the companion's 404 for threads started on the Mac. The fidelity summary gains rows for questions and approvals. Refs #281 Coven-Harness: Claude Code / claude-opus-5-5 * Record CF-8's request variants in status Refs #281 Coven-Harness: Claude Code / claude-opus-5-5 * Record the landed children in the acceptance receipt CF-2 (#286), CF-3 (#293), CF-4's Markdown slice (#283), CF-6's request half (#308) and CF-7's clarifications (#312) are on main, with their merge commits. The candidate note says the fixture rows now run on main, and no candidate is pinned while the live-provider and human gates stay open. Refs #281 Coven-Harness: Claude Code / claude-opus-5-5
This was referenced Oct 19, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clarification half of CF-7 (#280): a plan clarification is asked and answered through CF-3's question card, and the turn's task record and Notes keep it.
What changes
taskRecordlists every question the CLI asked during the turn, from its question cards, with the answer as the card shows it. A secret answer reads "(hidden)".docs/task-context.mddescribes clarifications. Codex asks throughitem/tool/requestUserInput; Claude Code 2.1.302 sends Modex no structured questions.Tests, red first
test/task-context.test.ts: the clarification record failed first; the record had noclarifications.e2e/plan-clarification.spec.ts(new) uses a scripted codex-cli 0.163.0 app-server. It reports a plan and asks a clarifying question on the card, then plans on from the answer.MODEX_HOMEholds the secret.## Clarificationsin the saved note.Checks
On
5f0959d, rebased ontomaind625eda(CF-6), macOS 26.7.1, Node v24.18.1, pnpm 10.34.5:pnpm buildat the root andpnpm typecheckinapps/desktop: passed.task-contextandrequest-journalunit tests: 12 of 12.main57e7607plus CF-6:pnpm test: 1,590 passed, 16 skipped, 0 failed; second stage 21 of 21.plan-clarification,task-to-notes,conversation-fidelity,typed-turns,human-requests: 18 of 18.maingained only docs (Record #185's downgrades in the approval spec; drop the merged parser from Still open #306), comments (Correct two comments that still describe the transcript's old Markdown #307) and CF-6's squash.pnpm test:e2e. CI runs it.All commits are signed.
docs/status.mdadds CF-7's clarifications under "On main, unreleased" and removes them from "Still open".Refs #280, #276. Tracker #273.